From dbf36cc599b84d5a6db127ba57f081fa2ac5e666 Mon Sep 17 00:00:00 2001 From: Nathaniel Wesley Filardo Date: Tue, 19 Feb 2019 00:58:24 +0000 Subject: [PATCH] Update some comments and whitespace --- .../java/com/acmetensortoys/ctfwstimer/MainService.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainService.java b/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainService.java index 35f3437..5ad5b46 100644 --- a/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainService.java +++ b/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainService.java @@ -88,7 +88,8 @@ public class MainService extends Service { } }; - // We'll use this common callback object for our subscriptions below + // We'll use this common callback object for our subscriptions below; all it does is trace + // events to the log for us private final IMqttActionListener subal = new IMqttActionListener() { @Override public void onSuccess(IMqttToken asyncActionToken) { @@ -100,6 +101,7 @@ public class MainService extends Service { Log.e("CtFws", "Sub Fail: " + asyncActionToken, exception); } }; + // And this handles making our subscriptions for us private class MyMQTTCallbacks implements MqttCallbackExtended { CtFwSCallbacksMQTT mCtfwscbs; @@ -180,7 +182,6 @@ public class MainService extends Service { } else { Log.d("Service", "IS STALE CONN"); try { - // TODO Should we waitforcompletion here? c.disconnect(); } catch (MqttException me) { // Drop it, we've already dropped the client handle @@ -300,8 +301,6 @@ public class MainService extends Service { } // Must hold strongly since Android only holds weakly once registered. - // TODO: Option for notification persistence during game? - // TODO: Option for polling even after game ends? private final SharedPreferences.OnSharedPreferenceChangeListener mOSPCL = new SharedPreferences.OnSharedPreferenceChangeListener() { @Override -- 2.50.1