From 545bac03a9bf0ede75cd15ab16651fd03b5153ba Mon Sep 17 00:00:00 2001
From: Nathaniel Wesley Filardo <nwf@cs.jhu.edu>
Date: Sat, 21 Oct 2017 01:59:25 -0400
Subject: [PATCH] Enable more fine-grained control of vibration

---
 .../ctfwstimer/MainServiceNotification.java   | 53 ++++++++++++++-----
 mobile/src/main/res/values/strings.xml        |  4 +-
 mobile/src/main/res/xml/preferences.xml       | 16 +++++-
 3 files changed, 56 insertions(+), 17 deletions(-)

diff --git a/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainServiceNotification.java b/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainServiceNotification.java
index c6a2872..5e025ec 100644
--- a/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainServiceNotification.java
+++ b/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainServiceNotification.java
@@ -19,9 +19,10 @@ class MainServiceNotification {
     final private MainService mService;
     private final NotificationCompat.Builder userNoteBuilder;
 
-    private long lastForegroundTime;
+    private long lastVibrateTime;
 
-    private enum LastContentTextSource { NONE, FLAG, MESG };
+    private enum VibrationSource { NONE, BREAK, FLAG, MESG }
+    private enum LastContentTextSource { NONE, FLAG, MESG }
     private LastContentTextSource lastContextTextSource = LastContentTextSource.NONE;
 
     MainServiceNotification(MainService ms, CtFwSGameState game){
@@ -68,7 +69,7 @@ class MainServiceNotification {
                         userNoteBuilder.setSubText(now.rationale);
                     }
 
-                    vibrate(VIBRATE_PATTERN_NOW);
+                    vibrate(VibrationSource.BREAK);
                     ensureNotification();
                 } else {
                     // game no longer afoot
@@ -84,7 +85,7 @@ class MainServiceNotification {
                 if (game.flagsVisible
                         && ((lastContextTextSource == LastContentTextSource.FLAG)
                             || (game.flagsRed + game.flagsYel > 0))) {
-                    vibrate(VIBRATE_PATTERN_FLAG);
+                    vibrate(VibrationSource.FLAG);
                     lastContextTextSource = LastContentTextSource.FLAG;
                     userNoteBuilder.setContentText(
                             String.format(mService.getResources().getString(R.string.notify_flags),
@@ -98,7 +99,7 @@ class MainServiceNotification {
                 // Only do anything if we aren't clearing the message list
                 int s = msgs.size();
                 if (s != 0) {
-                    vibrate(VIBRATE_PATTERN_MSG);
+                    vibrate(VibrationSource.MESG);
                     lastContextTextSource = LastContentTextSource.MESG;
                     userNoteBuilder.setContentText(msgs.get(s - 1).msg);
                     refreshNotification();
@@ -113,12 +114,42 @@ class MainServiceNotification {
     private final long[] VIBRATE_PATTERN_FLAG = {0, 100, 100, 100, 100, 300, 100, 100}; // 'F' = ..-.
     private final long[] VIBRATE_PATTERN_MSG  = {0, 300, 100, 300};                     // 'M' = --
 
-    private void vibrate(long[] pattern) {
-        SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(mService.getBaseContext());
+    private void vibrate(VibrationSource vs) {
+        long now = System.currentTimeMillis();
+
+        // Clobber the vibration request if we probably recently did such a thing
+        if ((now - lastVibrateTime < VIBRATE_SUPPRESS_THRESHOLD)) {
+            vs = VibrationSource.NONE;
+        }
+
+        String pref;
+        long[] pattern;
+
+        switch(vs) {
+            case BREAK:
+                pref = "prf_vibr_jb";
+                pattern = VIBRATE_PATTERN_NOW;
+                break;
+            case FLAG:
+                pref = "prf_vibr_flag";
+                pattern = VIBRATE_PATTERN_FLAG;
+                break;
+            case MESG:
+                pref = "prf_vibr_mesg";
+                pattern = VIBRATE_PATTERN_MSG;
+                break;
+            case NONE:
+            default:
+                userNoteBuilder.setVibrate(null);
+                return;
+        }
+
         // Cam: default value is "false" because we really don't want to be vibrating if we
         //      accidentally lose our preferences somehow
-        if (sp.getBoolean("prf_vibr", false)) {
+        if (PreferenceManager.getDefaultSharedPreferences(mService.getBaseContext())
+                .getBoolean(pref, false)) {
             userNoteBuilder.setVibrate(pattern);
+            lastVibrateTime = now;
         }
         else {
             userNoteBuilder.setVibrate(null);
@@ -128,14 +159,8 @@ class MainServiceNotification {
     private ServiceConnection userNoteSC;
     private void refreshNotification() {
         synchronized (this) {
-            long now = System.currentTimeMillis();
             if (userNoteSC != null) {
-                // Clobber the vibration request if we probably recently did such a thing
-                if (now - lastForegroundTime < VIBRATE_SUPPRESS_THRESHOLD){
-                    userNoteBuilder.setVibrate(null);
-                }
                 mService.startForeground(MainService.NOTE_ID_USER, userNoteBuilder.build());
-                lastForegroundTime = now;
             }
         }
     }
diff --git a/mobile/src/main/res/values/strings.xml b/mobile/src/main/res/values/strings.xml
index a7b4c1a..fa31c71 100644
--- a/mobile/src/main/res/values/strings.xml
+++ b/mobile/src/main/res/values/strings.xml
@@ -31,7 +31,9 @@
     <string name="mqtt_subbed">Subscribed</string>
 
     <string name="preftext_mqtt">Set MQTT Server</string>
-    <string name="preftext_vibrate">Vibrate?</string>
+    <string name="preftext_vibrate_jb">Vibrate on Jailbreak?</string>
+    <string name="preftext_vibrate_flag">Vibrate on Flag Capture?</string>
+    <string name="preftext_vibrate_mesg">Vibrate on Message?</string>
 
     <string name="string_null">&lt;&lt;null&gt;&gt;</string>
 
diff --git a/mobile/src/main/res/xml/preferences.xml b/mobile/src/main/res/xml/preferences.xml
index 67bf097..04c91d6 100644
--- a/mobile/src/main/res/xml/preferences.xml
+++ b/mobile/src/main/res/xml/preferences.xml
@@ -9,6 +9,18 @@
         android:title="@string/preftext_mqtt" />
     <CheckBoxPreference
         android:defaultValue="true"
-        android:title="@string/preftext_vibrate"
-        android:key="prf_vibr" />
+        android:key="prf_vibr_jb"
+        android:title="@string/preftext_vibrate_jb" />
+    <CheckBoxPreference
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:defaultValue="true"
+        android:key="prf_vibr_flag"
+        android:title="@string/preftext_vibrate_flag" />
+    <CheckBoxPreference
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:defaultValue="true"
+        android:key="prf_vibr_mesg"
+        android:title="@string/preftext_vibrate_mesg" />
 </PreferenceScreen>
-- 
2.50.1