From 0ab0536818558891733e5b20da4a8fe51b66ff06 Mon Sep 17 00:00:00 2001 From: rmceoin Date: Wed, 28 Oct 2009 00:35:00 +0000 Subject: [PATCH] OI Safe: corrected warnings about unused variables, set Min SDK to 3 to match with sdk-1.5 requirement. git-svn-id: http://openintents.googlecode.com/svn/trunk/Safe@2353 72b678ce-9140-0410-bee8-679b907dd61a --- AndroidManifest.xml | 2 +- src/estreamj/framework/Engine.java | 3 ++- src/org/openintents/distribution/AboutDialog.java | 2 +- src/org/openintents/distribution/EulaActivity.java | 1 - src/org/openintents/safe/Search.java | 1 + .../safe/dialog/AllowExternalAccessDialog.java | 4 ++-- src/org/openintents/safe/dialog/FilenameDialog.java | 4 ++-- .../safe/dialog/FirstTimeWarningDialog.java | 10 ++-------- 8 files changed, 11 insertions(+), 16 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 729d935..987d062 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -126,5 +126,5 @@ - + diff --git a/src/estreamj/framework/Engine.java b/src/estreamj/framework/Engine.java index 8d88859..48c0332 100644 --- a/src/estreamj/framework/Engine.java +++ b/src/estreamj/framework/Engine.java @@ -82,6 +82,7 @@ public class Engine // all the cipher classes must be listed here, the rest of the registration // is done via reflection; this is done by having every class implementing // a 'public static void register()' method (see below) + @SuppressWarnings("unchecked") static Class[] _cipherClasses = { //estreamj.ciphers.phelix.Phelix.class, @@ -110,7 +111,7 @@ public class Engine for (int i = 0; i < _cipherClasses.length; i++) { // check if the register method is there and static - Class cls = _cipherClasses[i]; + Class cls = _cipherClasses[i]; Method mthd = cls.getMethod("register", (Class[])null); if (Modifier.STATIC != (mthd.getModifiers() & Modifier.STATIC)) { diff --git a/src/org/openintents/distribution/AboutDialog.java b/src/org/openintents/distribution/AboutDialog.java index 258c744..4341b7d 100644 --- a/src/org/openintents/distribution/AboutDialog.java +++ b/src/org/openintents/distribution/AboutDialog.java @@ -32,7 +32,7 @@ import android.content.Intent; * */ public class AboutDialog extends GetFromMarketDialog { - private static final String TAG = "About"; +// private static final String TAG = "About"; public AboutDialog(Context context) { super(context, diff --git a/src/org/openintents/distribution/EulaActivity.java b/src/org/openintents/distribution/EulaActivity.java index 830d897..7293d36 100644 --- a/src/org/openintents/distribution/EulaActivity.java +++ b/src/org/openintents/distribution/EulaActivity.java @@ -11,7 +11,6 @@ import android.content.Intent; import android.content.SharedPreferences; import android.content.res.Resources; import android.os.Bundle; -import android.os.Parcel; import android.preference.PreferenceManager; import android.text.TextUtils; import android.util.Log; diff --git a/src/org/openintents/safe/Search.java b/src/org/openintents/safe/Search.java index 388200b..b373302 100644 --- a/src/org/openintents/safe/Search.java +++ b/src/org/openintents/safe/Search.java @@ -118,6 +118,7 @@ public class Search extends ListActivity { etSearchCriteria.setOnEditorActionListener(new TextView.OnEditorActionListener() { public boolean onEditorAction(TextView v, int actionId, KeyEvent event) { if (actionId == EditorInfo.IME_ACTION_SEARCH) { + // hide the soft keyboard InputMethodManager imm = (InputMethodManager)getSystemService(Context.INPUT_METHOD_SERVICE); imm.toggleSoftInput(0, 0); diff --git a/src/org/openintents/safe/dialog/AllowExternalAccessDialog.java b/src/org/openintents/safe/dialog/AllowExternalAccessDialog.java index f46ae0c..c6d9921 100644 --- a/src/org/openintents/safe/dialog/AllowExternalAccessDialog.java +++ b/src/org/openintents/safe/dialog/AllowExternalAccessDialog.java @@ -15,7 +15,7 @@ import android.view.View; import android.widget.CheckBox; public class AllowExternalAccessDialog extends AlertDialog implements OnClickListener { - private static final String TAG = "FilenameDialog"; +// private static final String TAG = "FilenameDialog"; private static final String BUNDLE_TAGS = "tags"; @@ -75,6 +75,6 @@ public class AllowExternalAccessDialog extends AlertDialog implements OnClickLis @Override public void onRestoreInstanceState(Bundle savedInstanceState) { super.onRestoreInstanceState(savedInstanceState); - String tags = savedInstanceState.getString(BUNDLE_TAGS); +// String tags = savedInstanceState.getString(BUNDLE_TAGS); } } diff --git a/src/org/openintents/safe/dialog/FilenameDialog.java b/src/org/openintents/safe/dialog/FilenameDialog.java index 2802224..9abfaaf 100644 --- a/src/org/openintents/safe/dialog/FilenameDialog.java +++ b/src/org/openintents/safe/dialog/FilenameDialog.java @@ -14,7 +14,7 @@ import android.widget.EditText; import android.widget.ImageButton; public class FilenameDialog extends AlertDialog implements OnClickListener { - private static final String TAG = "FilenameDialog"; +// private static final String TAG = "FilenameDialog"; private static final String BUNDLE_TAGS = "tags"; @@ -104,6 +104,6 @@ public class FilenameDialog extends AlertDialog implements OnClickListener { @Override public void onRestoreInstanceState(Bundle savedInstanceState) { super.onRestoreInstanceState(savedInstanceState); - String tags = savedInstanceState.getString(BUNDLE_TAGS); +// String tags = savedInstanceState.getString(BUNDLE_TAGS); } } diff --git a/src/org/openintents/safe/dialog/FirstTimeWarningDialog.java b/src/org/openintents/safe/dialog/FirstTimeWarningDialog.java index a1ef3b5..7447621 100644 --- a/src/org/openintents/safe/dialog/FirstTimeWarningDialog.java +++ b/src/org/openintents/safe/dialog/FirstTimeWarningDialog.java @@ -1,23 +1,17 @@ package org.openintents.safe.dialog; -import org.openintents.safe.Preferences; import org.openintents.safe.R; import android.app.AlertDialog; import android.content.Context; import android.content.DialogInterface; -import android.content.SharedPreferences; import android.content.DialogInterface.OnClickListener; -import android.os.Bundle; -import android.preference.PreferenceManager; -import android.view.LayoutInflater; -import android.view.View; import android.widget.CheckBox; public class FirstTimeWarningDialog extends AlertDialog implements OnClickListener { - private static final String TAG = "FilenameDialog"; +// private static final String TAG = "FilenameDialog"; - private static final String BUNDLE_TAGS = "tags"; +// private static final String BUNDLE_TAGS = "tags"; protected static final int DIALOG_ID_NO_FILE_MANAGER_AVAILABLE = 2; -- 2.50.1