From: Nathaniel Wesley Filardo <nwf@cs.jhu.edu>
Date: Fri, 24 Feb 2017 19:39:42 +0000 (-0500)
Subject: Move default string to string xml and reference
X-Git-Tag: release-1.2~37
X-Git-Url: https://hydra-www.ietfng.org/gitweb/?a=commitdiff_plain;h=679e90f1707159f3e90391e7c06e277985e0e46f;p=acmetensortoys-ctfws-android

Move default string to string xml and reference
---

diff --git a/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainActivity.java b/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainActivity.java
index 7169fc3..a5e17a6 100644
--- a/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainActivity.java
+++ b/mobile/src/main/java/com/acmetensortoys/ctfwstimer/MainActivity.java
@@ -19,10 +19,6 @@ import android.view.View;
 import android.widget.TextView;
 
 public class MainActivity extends AppCompatActivity {
-
-    // TODO surely this belongs somewhere else
-    private static final String defserver = "tcp://ctfws-mqtt.ietfng.org:1883";
-
     private final MainActivityBuildHooks mabh = new MainActivityBuildHooksImpl();
 
     private MainService.LocalBinder mSrvBinder; // set once connection completed
@@ -68,7 +64,7 @@ public class MainActivity extends AppCompatActivity {
 
         SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(this);
         if (sp.getString("server", null) == null) {
-            sp.edit().putString("server", defserver).apply();
+            sp.edit().putString("server", getString(R.string.server_default)).apply();
         }
         if (BuildConfig.DEBUG && sp.getString("server", null) == null) {
             throw new AssertionError("Shared Preferences not sticking!");
diff --git a/mobile/src/main/res/values/strings.xml b/mobile/src/main/res/values/strings.xml
index e035cef..d737a53 100644
--- a/mobile/src/main/res/values/strings.xml
+++ b/mobile/src/main/res/values/strings.xml
@@ -1,4 +1,6 @@
 <resources xmlns:tools="http://schemas.android.com/tools">
+    <string name="server_default">tcp://ctfws-mqtt.acmetensortoys.com:1883</string>
+
     <string name="app_name">CMUKGB CtFwS Timer</string>
 
     <string name="ctfws_gameend">Game\nEnd</string>
diff --git a/mobile/src/main/res/xml/preferences.xml b/mobile/src/main/res/xml/preferences.xml
index a3734ac..67bf097 100644
--- a/mobile/src/main/res/xml/preferences.xml
+++ b/mobile/src/main/res/xml/preferences.xml
@@ -5,10 +5,10 @@
         android:selectAllOnFocus="true"
         android:singleLine="true"
         android:key="server"
-        android:defaultValue="tcp://ctfws-mqtt.ietfng.org:1883"
+        android:defaultValue="@string/server_default"
         android:title="@string/preftext_mqtt" />
     <CheckBoxPreference
         android:defaultValue="true"
         android:title="@string/preftext_vibrate"
         android:key="prf_vibr" />
-</PreferenceScreen>
\ No newline at end of file
+</PreferenceScreen>