From: Jordi Albornoz <jordi@src.gnome.org>
Date: Thu, 5 Dec 2002 12:42:01 +0000 (+0000)
Subject: Fix memleak, spotted by Wichert Akkerman. closedir() before jumping to "too_many_themes".
X-Git-Url: https://hydra-www.ietfng.org/gitweb/?a=commitdiff_plain;h=520d8f971ab2006125891e67ab34718f4e69bba0;p=gtetrinet

Fix memleak, spotted by Wichert Akkerman. closedir() before jumping to "too_many_themes".
Add more porting issues.
---

diff --git a/ChangeLog b/ChangeLog
index 9369835..479e55a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2002-12-05  Jordi Mallach  <jordi@sindominio.net>
+
+	* src/dialogs.c (prefdialog_themelist): fix memleak, spotted by
+	Wichert Akkerman. closedir() before jumping to "too_many_themes".
+
+	* TODO: add more porting problems.
+
 2002-12-03  Jordi Mallach  <jordi@sindominio.net>
 
 	* src/tetrinet.c (tetrinet_inmessage): patch from Niko Böhm, fixes
diff --git a/TODO b/TODO
index e0de322..85b5e2e 100644
--- a/TODO
+++ b/TODO
@@ -7,5 +7,7 @@ GTetrinet's TODO list
   + keybindings
   + toolbar icons/labels
   + replace GTK_CLIST
-  + text widgets slowness
+  + not able to select text on partyline
+  + multiple about windows
+  + playfields messages cleared when games start
 - Make gtetrinet resizeable.
diff --git a/src/dialogs.c b/src/dialogs.c
index 8ad20ab..7619fba 100644
--- a/src/dialogs.c
+++ b/src/dialogs.c
@@ -604,6 +604,7 @@ void prefdialog_themelist ()
                     if (themecount == (sizeof(themes) / sizeof(themes[0])))
                     { /* FIXME: should be dynamic */
                       g_warning("Too many theme files.\n");
+                      closedir (d);
                       goto too_many_themes;
                     }
                 }