Check that pnum < 0, not <= for IN_LVL, probably an oversight in the

2006-09-02  Jordi Mallach  <jordi@sindominio.net>

	* src/tetrinet.c: Check that pnum < 0, not <= for IN_LVL,
	probably an oversight in the security patch.

	* doc/gtetrinet.6: Patch from Nelson A. de Oliveira to correct
	some minor bugs in the manpage (Debian Bug#325662).

	* NEWS: Updated for 0.7.10.

diff --git a/ChangeLog b/ChangeLog
index bc15deafe16bbd743b88e9b070e48b1e6b04f703..001fc611fe26c0808dbbd8f195084c3090bbeead 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,8 +1,13 @@
 2006-09-02  Jordi Mallach  <jordi@sindominio.net>
 
+       * src/tetrinet.c: Check that pnum < 0, not <= for IN_LVL,
+       probably an oversight in the security patch.
+
        * doc/gtetrinet.6: Patch from Nelson A. de Oliveira to correct
        some minor bugs in the manpage (Debian Bug#325662).
 
+       * NEWS: Updated for 0.7.10.
+
 2006-08-17  Jordi Mallach  <jordi@sindominio.net>
 
        * src/tetrinet.c: [CVE-2006-3125] Add index underflow protections
@@ -44,7 +49,7 @@
        * src/client.c: Patch from Julien Plissonneau Duquène to
        fix network latency.
 
-       * NEWS: pdate for 0.7.9.
+       * NEWS: Update for 0.7.9.
 
 2005-04-15  Dani Carbonell  <bocata@panete.net>
 

diff --git a/NEWS b/NEWS
index 51ef27e0431ac2beeeba1bab2b5fb5e5da400720..e74d410a63f0ebb355c3a496f3dbda05efc7f9f1 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,14 @@
+GTetrinet 0.7.10 - 2006-09-02
+- SECURITY RELEASE -- Ref. CVE-2006-3125
+- Add index undeflow protections in network code.
+- Require GTK+ 2.6.0.
+- Fixed manpage typos.
+- Require new intltool and move ALL_LINGUAS to po/LINGUAS.
+- New and updated translations: Bulgarian (Alexander Shopov),
+  Basque (Iñaki Larrañaga), Traditional Chinese (Abel Cheung),
+  German (Jens Seidel), Nepali (Pawal Chitrakar), Finnish (Ilkka Tuohela),
+  Vietnamese (Clytie Siddall).
+
 GTetrinet 0.7.9 - 2005-04-29
 - Revamped encoding of data handling, fixing the output in partyline, etc.
   when using UTF-8 locales (Vidar Holen).

diff --git a/src/tetrinet.c b/src/tetrinet.c
index 847264366ea0f9bf1b873536ca76275bf83a54b6..297b34fd18e0f88156d3e3203aa4d5fcbb7103b9 100644 (file)
--- a/src/tetrinet.c
+++ b/src/tetrinet.c
@@ -737,7 +737,7 @@ void tetrinet_inmessage (enum inmsg_type msgtype, char *data)
             token = strtok (data, " ");
             if (token == NULL) break;
             pnum = atoi (token);
-            if (pnum >= MAX_PLAYERS || pnum <= 0)
+            if (pnum >= MAX_PLAYERS || pnum < 0)
               break;
             token = strtok (NULL, "");
             if (token == NULL) break;