Fix memleak, spotted by Wichert Akkerman. closedir() before jumping to "too_many_themes".

Add more porting issues.

diff --git a/ChangeLog b/ChangeLog
index 93698357da3567f483dc6b1a2d4f461996377128..479e55abe44740e6e0863337cd2b27cb96076bcc 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2002-12-05  Jordi Mallach  <jordi@sindominio.net>
+
+       * src/dialogs.c (prefdialog_themelist): fix memleak, spotted by
+       Wichert Akkerman. closedir() before jumping to "too_many_themes".
+
+       * TODO: add more porting problems.
+
 2002-12-03  Jordi Mallach  <jordi@sindominio.net>
 
        * src/tetrinet.c (tetrinet_inmessage): patch from Niko Böhm, fixes

diff --git a/TODO b/TODO
index e0de322af2de909b9a71040c316cbf2050ef3681..85b5e2e4b19beaa5f5df078da9382b4911b93f69 100644 (file)
--- a/TODO
+++ b/TODO
@@ -7,5 +7,7 @@ GTetrinet's TODO list
   + keybindings
   + toolbar icons/labels
   + replace GTK_CLIST
-  + text widgets slowness
+  + not able to select text on partyline
+  + multiple about windows
+  + playfields messages cleared when games start
 - Make gtetrinet resizeable.

diff --git a/src/dialogs.c b/src/dialogs.c
index 8ad20abad0fc8c80e3b3ef3b6169587fcaaf8962..7619fba78247b35034930404a3a0795517bf3da1 100644 (file)
--- a/src/dialogs.c
+++ b/src/dialogs.c
@@ -604,6 +604,7 @@ void prefdialog_themelist ()
                     if (themecount == (sizeof(themes) / sizeof(themes[0])))
                     { /* FIXME: should be dynamic */
                       g_warning("Too many theme files.\n");
+                      closedir (d);
                       goto too_many_themes;
                     }
                 }